Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we not add prettier as a dev dependency? #5941

Closed
hhimanshu opened this issue Dec 1, 2018 · 1 comment
Closed

Should we not add prettier as a dev dependency? #5941

hhimanshu opened this issue Dec 1, 2018 · 1 comment

Comments

@hhimanshu
Copy link

I am following up https://facebook.github.io/create-react-app/docs/setting-up-your-editor#formatting-code-automatically article where the code to add prettier (and related dependencies) is mentioned as

NPM

npm install --save husky lint-staged prettier

Yarn

yarn add husky lint-staged prettier

Considering that they are using at the development time, should they be added as devDependencies?

NPM

npm install --save-dev husky lint-staged prettier

Yarn

yarn add --dev husky lint-staged prettier

It is also mentioned in Prettier's own documentation

Thanks
@hhimanshu hhimanshu changed the title Should we not add prettier in dev dependency? Should we not add prettier as a dev dependency? Dec 1, 2018
@iansu
Copy link
Contributor

iansu commented Dec 1, 2018

This is intentional. There are many closed issues and PRs related to this. There's also an open PR that adds an explanation for this to the docs: #5885

@iansu iansu closed this as completed Dec 1, 2018
@lock lock bot locked and limited conversation to collaborators Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants