Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force on some TypeScript options at the loader #5604

Closed
Timer opened this issue Oct 28, 2018 · 2 comments
Closed

Force on some TypeScript options at the loader #5604

Timer opened this issue Oct 28, 2018 · 2 comments
Labels
issue: bug issue: typescript
Milestone
2.1

Comments

@Timer
Copy link
Contributor

Timer commented Oct 28, 2018

We force some on in tsconfig.json but the user could always overwrite them after boot. We need to prevent this to stop obscure bugs.
@Timer Timer added this to the 2.1 milestone Oct 28, 2018
@7399gem
Copy link

7399gem commented Oct 28, 2018

This is corrupt and has taken my privacy away

@Timer
Copy link
Contributor Author

Timer commented Oct 28, 2018

This is corrupt and has taken my privacy away

I'm sorry you feel that way, @7399gem. This issue is pertaining to required tsconfig.json settings that, if set different, break the build. We're doing this to prevent undefined behavior.

@Timer Timer mentioned this issue Oct 28, 2018
Merged
@lock lock bot locked and limited conversation to collaborators Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue: bug issue: typescript
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
2 participants
@Timer @7399gem