Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official TypeScript support #3415

Closed
bootstraponline opened this issue Nov 5, 2017 · 6 comments
Closed

Official TypeScript support #3415

bootstraponline opened this issue Nov 5, 2017 · 6 comments

Comments

@bootstraponline
Copy link

bootstraponline commented Nov 5, 2017

Is there any interest in officially supporting TypeScript in create-react-app? I think having to fork the repo to add support is a bit unfortunate.

Creating a react-scripts only fork is nice, however there's still a bunch of lightly modified upstream code.

@ianschmitz
Copy link
Contributor

ianschmitz commented Nov 6, 2017

There is also https://github.com/timarney/react-app-rewired but i'm not sure how far that will get you compared to react-scripts-ts.

Also a bunch of related info with regards to maintaining a fork: #682

@bootstraponline
Copy link
Author

bootstraponline commented Nov 6, 2017

TypeScript support is only ~254 lines of code. Rebasing is painful.

react-app-rewired is missing most of the features in create-react-app-typescript. ts-jest is unsupported by react-app-rewire-typescript.

@andriijas
Copy link
Contributor

Make a PR to react-app-rewire-typescript to add ts-jest or write your own react-app-rewire plugin, its easy.

imo typescript doesnt belong in CRA.

@Timer
Copy link
Contributor

Timer commented Nov 7, 2017

Hi there! We're not quite ready to consider this yet but you can keep track of our Plugin System (#2784) and TypeScript Plugin (#2815).

@Timer Timer closed this as completed Nov 7, 2017
@bootstraponline
Copy link
Author

Make a PR to react-app-rewire-typescript to add ts-jest or write your own react-app-rewire plugin, its easy.

I don't think react-app-rewire is the answer. There are known issues with that approach.

The Plugin System looks amazing. Hopefully that gets merged soon.

@Timer
Copy link
Contributor

Timer commented Oct 30, 2018

TypeScript is now officially supported as of Create React App 2.1. Read the release notes to get started!

@lock lock bot locked and limited conversation to collaborators Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants