Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to editor from build time overlay #2805

Closed
gaearon opened this issue Jul 17, 2017 · 3 comments
Closed

Jump to editor from build time overlay #2805

gaearon opened this issue Jul 17, 2017 · 3 comments

Comments

@gaearon
Copy link
Contributor

gaearon commented Jul 17, 2017

After both overlays share the code we can try to implement click-to-jump for build-time overlay as well. This would be cool both for linting and compile errors. It would probably involve some parsing since we won't have access to structured data.

@markspolakovs
Copy link

This seems like something that would easily break forked react-scripts (for example, react-scripts-ts's TypeScript error messages probably use a different format).

@Timer
Copy link
Contributor

Timer commented Aug 9, 2017

This feature would need to be implemented by that fork then. It's up to them if they choose to forego it. :)

@tharakawj
Copy link
Contributor

Resolved by #3100

@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants