BROWSER=none not working - react-dev-utils package from npm not up-to-date with git?

[beac0n]

Can you reproduce the problem with latest npm?

yes

Description

I wanted to use the BROWSER=none option, to prevent react-scripts from opening a new Browser.
Setting the env variable did not work at all.

after checking the openBrowser.js file in node_modules/react-dev-utils/ I realized, that it is different
from the openBrowser.js in the github repo:

/**

• Copyright (c) 2015-present, Facebook, Inc.
• All rights reserved.
• This source code is licensed under the BSD-style license found in the
• LICENSE file in the root directory of this source tree. An additional grant
• of patent rights can be found in the PATENTS file in the same directory.
  */

var execSync = require('child_process').execSync;
var opn = require('opn');

function openBrowser(url) {
if (process.platform === 'darwin') {
try {
// Try our best to reuse existing tab
// on OS X Google Chrome with AppleScript
execSync('ps cax | grep "Google Chrome"');
execSync(
'osascript openChrome.applescript ' + url,
{cwd: __dirname, stdio: 'ignore'}
);
return true;
} catch (err) {
// Ignore errors.
}
}
// Fallback to opn
// (It will always open new tab)
try {
opn(url).catch(() => {}); // Prevent unhandledRejection error.
return true;
} catch (err) {
return false;
}
}

This file does not contain the check for BROWSER=none, but in
https://github.com/facebookincubator/create-react-app/blob/master/packages/react-dev-utils/openBrowser.js
it exists.

Expected behavior

using the env variable like BROWSER=none should prevent react-scripts from opening the browser

Actual behavior

When using BROWSER=none, the Browser still opens

Environment

Run these commands in the project folder and fill in their results:

1. npm ls react-scripts (if you haven’t ejected):
   wine-page@0.1.0 /home/beac0n/dev/wine-page
   └── react-scripts@0.8.5

2. node -v: v7.5.0

3. npm -v: 4.1.2

4. Operating system:
   Arch Linux

I could reproduce the issue when creating a new project with create-react-app 1.0.3.
I also ran npm cache clean, yarn cache clean - both commands with sudo and without.

I also downloaded the bundle manually from the npm registry:
https://registry.npmjs.org/react-dev-utils/-/react-dev-utils-0.4.2.tgz

The openBrowser.js file still isn't the same as in the github repository.

[gaearon]

The change was done in master but 0.9.0 has not been released yet. It will be released soon.

[gaearon]

0.9.0 is out now with support for this.

[beac0n]

upgraded to 0.9.0, which resolved this issue :). Thanks a lot 👍

[lennerd]

Sorry, maybe I'm stupid but how were you able to update? I'm using react-dev-utils for our build setup and, I mean react-dev-utils is still on 0.5.2, no?

https://github.com/facebookincubator/create-react-app/blob/master/packages/react-dev-utils/package.json#L3

[Timer]

0.9.0 refers to the version of react-scripts, not react-dev-utils. You have the latest version.

[lennerd]

Okay, than the information in CHANGELOG are very confusing. 🙈

https://github.com/facebookincubator/create-react-app/blob/master/CHANGELOG.md#094-march-6-2017

It's saying that the version 0.9.4 contains some fixes published on the 9th of March. So now I guess 0.9.4 stands only for the create-react-app package version, right? That's were the confusion starts at least to me. It would help if the CHANGELOG also contains the version numbers of the child packages so it's easier to track them if you use them separately.

Than again I'm looking for changes from the PR #1546 which were merged on 15th of February.
This PR is adding the content-changed message to the client socket implementation to reload the page when files in the contentBase (/public) changed.

15th of February vs. 9th of March, but not part of the package? Looking into the webpackHotDevClient.js file from the latest release, the changes from #1546 are indead also not part of 0.9.4:

https://github.com/facebookincubator/create-react-app/blob/v0.9.4/packages/react-dev-utils/webpackHotDevClient.js#L247-L265

So apart from all this I'm also confused by the fact that older changes than the latest ones are not part of the latest version of the package. 🙈 😅

[lennerd]

Ah, now looking at #1546 a little closer I see that it changes are scheduled for 0.10.x by @gaearon. So you seem to cherry-pick changes from the current master?

Also, why is this scheduled for the next minor version? Worried about anything?

Apart from changes in a public folder, I would really love to reload the page in certain situation via webpackHotDevClient.

[gaearon]

Changelog uses versions of react-scripts because that's the thing most people will upgrade. For other packages it's easiest to figure out what changes by looking at folder git history.

#1546 only works with Webpack 2 (afaik). So it's not released until we release a version of react-scripts compatible with Webpack 2.

Yea, we cherry-pick stable branch from master now but the next release will be done from master.

[lennerd]

Thank you for the explanations. I found and started to use the 0.6.0-beta release, so I can use the content reloading now.