Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up an end-to-end test #10

Closed
gaearon opened this issue Jul 17, 2016 · 4 comments
Closed

Set up an end-to-end test #10

gaearon opened this issue Jul 17, 2016 · 4 comments
Milestone

Comments

@gaearon
Copy link
Contributor

gaearon commented Jul 17, 2016

This is boring but needed.

Write a script we can run on Travis that tests that create-react-app something && cd something && npm run build produces a build without error in the build folder, and that npm run eject (aka "graduate" before #9 is fixed) changes the project in a way that npm run build also works.

@vjeux
Copy link
Contributor

vjeux commented Jul 17, 2016

I'd love to have a dummy test that ensures that npm start does not instant fatal as well

@vjeux
Copy link
Contributor

vjeux commented Jul 17, 2016

Test is here: d3f9305

Next step: hooking it up to travis

@vjeux
Copy link
Contributor

vjeux commented Jul 17, 2016

Travis is not setup for facebookincubator repo yet. I'll ping the relevant people tomorrow (outside of the weekend). In the meantime this should work (tm) https://github.com/facebookincubator/create-react-app/blob/master/.travis.yml

@vjeux vjeux added this to the 0.1.0 milestone Jul 18, 2016
@vjeux
Copy link
Contributor

vjeux commented Jul 18, 2016

Travis is working :)))

https://travis-ci.com/facebookincubator/create-react-app/builds/28471455

@vjeux vjeux closed this as completed Jul 18, 2016
@lock lock bot locked and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants