You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This struct is missing output_symlinks and the 2 deprecated fields output_file_symlinks and output_directory_symlinks that allow the remote executor to return symlink outputs to the client.
In some special cases, output_symlinks could be used to create dangling symlinks (symlinks with target could not be resolved on the build environments) to support some packaging rules. I.e. an RPM may contain symlinks with targets that only exist in the production environment.
The text was updated successfully, but these errors were encountered:
This is one blocker (among others) for buck2-nix using RE currently, because some of my build rules output symlinks to /nix/store, which is another use case for this. That will definitely have to come sometime after #193 lands, of course.
I think it shouldn't be very hard to include (PRs welcome, it sounds from your comments on #220 that you might be doing this), and the callsites probably need little changing to account for it. We don't actually have a backend that supports those internally, however so that'd need a little testing somewhere else.
Currently, buck2 is wrapping RE's ActionResult with
TActionResult2
buck2/remote_execution/oss/re_grpc/src/response.rs
Lines 72 to 83 in e140880
This struct is missing
output_symlinks
and the 2 deprecated fieldsoutput_file_symlinks
andoutput_directory_symlinks
that allow the remote executor to return symlink outputs to the client.In some special cases,
output_symlinks
could be used to create dangling symlinks (symlinks with target could not be resolved on the build environments) to support some packaging rules. I.e. an RPM may contain symlinks with targets that only exist in the production environment.The text was updated successfully, but these errors were encountered: