Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is correct the use of cookie lib? #23

Closed
jorgecasar opened this issue Feb 21, 2019 · 2 comments
Closed

Is correct the use of cookie lib? #23

jorgecasar opened this issue Feb 21, 2019 · 2 comments

Comments

@jorgecasar
Copy link

I opened a PR to request ES Modules syntax support and a member of the library notify that maybe this library is using cookie library incorrectly.

jshttp/cookie#87 (comment)

@fabulator
Copy link
Owner

Thanks for info. They are partially right. Their parse method won't parse whole set Cookies response. I just use it for part that is same. And same as for serializer. I'm using this library for several projects and for basic usage it is fine. I want to know only key value and I don't care about expire or domain parameters...

@jorgecasar
Copy link
Author

Thanks, It's I thought. I hope the decide to distribute it as modules for better integration with this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants