[Bug]: rc2 break ActiveSelection if through group select

[ritali4912]

CheckList

• I agree to follow this project's Code of Conduct
• I have read and followed the Contributing Guide
• I have read and followed the Issue Tracker Guide
• I have searched and referenced existing issues and discussions
• I am filing a BUG report.
• I have managed to reproduce the bug after upgrading to the latest version
• I have created an accurate and minimal reproduction

Version

6.0.0-rc2

In What environments are you experiencing the problem?

Microsoft Edge

Node Version (if applicable)

None

Link To Reproduction

https://jsfiddle.net/ritali4912/deartfzo/30/

Steps To Reproduce

1. Create 2 rect
2. Make them in ActiveSelection through group select (mouse down then move to select them)
3. Check the Active Selection

Expected Behavior

In beta 20, it is correct.

Actual Behavior

In rc2, the bounds of the ActiveSelection change to {left: 0, top: 0, width: 0, height: 0}

I check the code, and found it caused by the improper set properties timing. Especially If the user change the originX, originY which will impact on the layout result.
And with bellow change, I can get correct result.
Please evaluate and help to fix it in next release.

Error Message & Stack Trace

No response

[asturur]

hi @ritali4912 can you check the latest master? it seems ok to me. I think we also have a test case for this interaction (i'll verify )

[asturur]

i updated rc3, let me know if it changes anything, otherwise i ll mark as a bug and fix

[asturur]

ok i see the point, i have to uncomment the originX to actually make the issue happen with latest master.
Please make tidier reproduction case:

actual reproduction case

export async function testCase(canvas: fabric.Canvas) {
  const utahCommonDefaults = {
    originX: 'center' as const,
    originY: 'center' as const,
  };

  fabric.ActiveSelection.ownDefaults = {
    ...fabric.ActiveSelection.ownDefaults,
    ...utahCommonDefaults,
  };

  fabric.Rect.ownDefaults = {
    ...fabric.Rect.ownDefaults,
    ...utahCommonDefaults,
  };

  const rect = new fabric.Rect({ width: 500, height: 500, fill: 'blue' });
  const rect2 = new fabric.Rect({ width: 500, height: 500, fill: 'blue' });

  canvas.add(rect, rect2);
}

[ritali4912]

@asturur
Yes, I just update to rc3, the issue still here.
If you make the ActiveSelection through mouse click rect1 + shift click rect2, it is correct.
But group select is wrong.

As my above picture.
The below code initial the ActiveSelection with default properties, for example: originX: left, originY: top
and return with a bound based on {left, top}.
super(objects, { layoutManager: layoutManager ?? new ActiveSelectionLayoutManager() });

But then the follow code with set the bound to all 0.
Object.assign(this, ActiveSelection.ownDefaults); this.setOptions(options);

[ritali4912]

@asturur
Ah, I'm sorry for the uncomment code.
Yes, in my case, I need the originX: 'center', originY: 'center'.

But from the logic, I think it is no matter what value of originX, originX.

[asturur]

@ritali4912 check the fix here: #9940 and please have a look that the added e2e test represent your use case

[ritali4912]

@asturur
I verified the 9940, it works.