Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional filters (mask and colourize/duotint) and code reuse. #624

Closed
aleph1 opened this issue May 10, 2013 · 9 comments
Closed

Additional filters (mask and colourize/duotint) and code reuse. #624

aleph1 opened this issue May 10, 2013 · 9 comments

Comments

@aleph1
Copy link
Contributor

aleph1 commented May 10, 2013

I am using Fabric.js for an upcoming project, and have created two custom filters — one for masking an image based upon another image, and another that colourizes an image based on a set of two colours. In the process of creating the masking filter, I also identified some code that could be moved to utils to simplify the creation of filters that require two images an inputs like my mask one does.

Should I submit a pull request for the filters and/or the core code change?

@kangax
Copy link
Member

kangax commented May 10, 2013

Sure, I'd gladly look through it. We can include additional filters in Fabric since filters is an optional module.

@kangax kangax closed this as completed May 17, 2013
@Kienz
Copy link
Collaborator

Kienz commented May 27, 2013

@aleph1 Any news?

@aleph1
Copy link
Contributor Author

aleph1 commented May 27, 2013

I should be able to upload preliminary versions by mid-week. Have been busy with client work.

On 2013-05-27, at 4:23 AM, Stefan Kienzle notifications@github.com wrote:

@aleph1 Any news?


Reply to this email directly or view it on GitHub.

@Micks22
Copy link

Micks22 commented Oct 16, 2013

@aleph1 : I need filter "masking an image based upon another image" cn u pls share the code?

@Kienz
Copy link
Collaborator

Kienz commented Oct 16, 2013

@Micks22 fabric.Image.filters.Mask still exists. http://fabricjs.com/docs/fabric.Image.filters.Mask.html
At the moment we have no example/demo for that filter. But you can find an example here: http://resources.aleph-1.com/mask/. This can be differ a little bit from fabric's implementation.

@vijaygurjar
Copy link

Hi,

I have added mask image by another png image by referring "http://resources.aleph-1.com/mask/"
But mask not properly applied. Please help me to apply png mask over another image. I am just new in HTML5.

Regards,
Vijay

@DanieleSassoli
Copy link
Contributor

@vijaygurjar, give a look at #2531 .

@vijaygurjar
Copy link

Thanks @DanieleSassoli. Its working fine for me.
I have one query:
I want to zoom and pan inner image not selection area is it possible.

@DanieleSassoli
Copy link
Contributor

I wouldn't know how to do this with standard fabric image class, I have created my own class to accomplish this( and a lot of other feautres), which I hope I will be able to commit in the main fabricjs repo in a near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants