Object.toCanvasElement doesn't work well for objects in a selection

[av01d]

I'm using Object.toCanvasElement to generate thumbnails of all objects on canvas.
This works beautifully, except for objects that are part of the active selection.

Version

3.4.0

Test Case

http://misc.avoid.org/fabricjs-bug/
(jsfiddle.net is down at this moment)

Information about environment

Nodejs or browser? browser
Which browsers? all

Steps to reproduce

see fiddle

Expected Behavior

Object.toCanvasElement should render all objects on canvas correctly, even if they're part of a selection.

Actual Behavior

Objects part of a selection aren't rendered correctly.

[asturur]

hi @av01d , i look into this asap.
I would expect it to work for both single objects and full selection and objects inside selection.
I would like to know the code you are using because toCanvasElement has so many options.

[av01d]

view-source:http://misc.avoid.org/fabricjs-bug/

function showThumbs() {
	var div = document.getElementById('thumbs');
	div.innerHTML = '';
	
	var objs = fabricCanvas.getObjects();
	for (var i = 0; i < objs.length; i++) {
		var obj = objs[i], mw = 100, mh = 75, ow = obj.width, oh = obj.height, canvas;
		var canvas = obj.toCanvasElement({multiplier:Math.min(mw/ow, mh/oh),withoutTransform:true});
		var thumb = document.createElement('div');
		thumb.className = 'thumb';
		thumb.appendChild(canvas);
		thumbs.appendChild(thumb);
	}
}

fabricCanvas.on({
	'selection:created': showThumbs,
	'selection:updated': showThumbs,
	'selection:cleared': showThumbs,
	'object:added': showThumbs,
	'object:modified': showThumbs
});

The important bit is this:

var canvas = obj.toCanvasElement({multiplier:0.2,withoutTransform:true});

The multiplier doesn't matter, can be anything. Omitting withoutTransform also makes no difference.

I've tried playing with the options for toCanvasElement, doesn't seem to make a difference.

[asturur]

ok so you are using without transform, and you are applying a custom multiplier.
What happens if you run it with default options? do you get bit correct thumbs, or still wrong?

[av01d]

Still wrong. I've updated the example on http://misc.avoid.org/fabricjs-bug/
Here's the example as ZIP, so you can run it locally: http://misc.avoid.org/fabricjs-bug/bug.zip

[asturur]

This should be fixed asap and i do not think it should be hard.

[av01d]

Cool! You'll be rewarded ;-)

[asturur]

The Pr fixes the most obvious wrong behaviour.
I wonder what should be the interaction of withoutTransform and the group scaling.