Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object._getLeftTopCoords gets left center point #1950

Closed
lukejagodzinski opened this issue Jan 27, 2015 · 1 comment · Fixed by #2127
Closed

Object._getLeftTopCoords gets left center point #1950

lukejagodzinski opened this issue Jan 27, 2015 · 1 comment · Fixed by #2127
Assignees
Labels

Comments

@lukejagodzinski
Copy link

I've noticed that function Object._getLeftTopCoords look like follows:

function () {
  return this.translateToOriginPoint(this.getCenterPoint(), 'left', 'center');
} 

This function is used for transforming canvas for text rendering and maybe there is the reason to take left, center point but as name suggests it should take left, top point. Am I right? :)

@asturur
Copy link
Member

asturur commented Apr 19, 2015

Yes you are right, this is wrong.
Luckily this function does not get called by any situation as of now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants