Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: When the text is being edited, toDataURL unexpectedly creates additional cursors #10406

Open
7 tasks done
zhe-he opened this issue Jan 22, 2025 · 3 comments
Open
7 tasks done
Assignees
Labels

Comments

@zhe-he
Copy link
Contributor

zhe-he commented Jan 22, 2025

CheckList

  • I agree to follow this project's Code of Conduct
  • I have read and followed the Contributing Guide
  • I have read and followed the Issue Tracker Guide
  • I have searched and referenced existing issues and discussions
  • I am filing a BUG report.
  • I have managed to reproduce the bug after upgrading to the latest version
  • I have created an accurate and minimal reproduction

Version

6.0.2

In What environments are you experiencing the problem?

No response

Node Version (if applicable)

None

Link To Reproduction

https://codepen.io/zhe-he-the-vuer/pen/PwYyPWV?editors=0010

Steps To Reproduce

  1. Create a textbox.
  2. Focus on it.
  3. Call toDataURL({ multiplier: 2 }) (with 1x scale, two cursors will overlap, making it hard to notice).

Expected Behavior

The extra cursor and the extra selection area are no longer displayed.

Actual Behavior

Image

Error Message & Stack Trace

@asturur
Copy link
Member

asturur commented Jan 23, 2025

this is here since we inverted the cursor animation.
I want to fix this, but i want to look exactly why it happen, if it is a non clearing issue or else

@asturur asturur added the bug label Jan 23, 2025
@asturur asturur self-assigned this Jan 23, 2025
@zhe-he
Copy link
Contributor Author

zhe-he commented Jan 24, 2025

It is because toDataURL calls the toCanvasElement method, and toCanvasElement creates a new canvas to re-render all the graphics, which triggers...

@asturur
Copy link
Member

asturur commented Jan 24, 2025

I wouldn't expect the top canvas to be involved, that's why i m curious

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants