Model getters have different annotations than fields (breaks native)

[manusa]

There are still some methods that are not annotated like in io.fabric8.kubernetes.api.model.ObjectMeta (annotations, labels):

    @JsonProperty("annotations")
    @JsonInclude(JsonInclude.Include.NON_EMPTY)
    private Map<String, String> annotations = new LinkedHashMap<String, String>();

    @JsonProperty("annotations")
    public Map<String, String> getAnnotations() {
        return annotations;
    }

    @JsonProperty("annotations")
    public void setAnnotations(Map<String, String> annotations) {
        this.annotations = annotations;
    }

Originally posted by @jorsol in #6086 (comment)

[manusa]

OK, this has to do with the Fabric8DefaultRule which should really extend a different Rule. DefaultRule should be used to provide default values for fields and not to annotate fields.

Logic in this class should be moved to KubernetesCoreTypeAnnotator inside the propertyField method:

kubernetes-client/kubernetes-model-generator/kubernetes-model-jsonschema2pojo/src/main/java/io/fabric8/kubernetes/jsonschema2pojo/KubernetesCoreTypeAnnotator.java

Line 222 in 5136bb0

public void propertyField(JFieldVar field, JDefinedClass clazz, String propertyName, JsonNode propertyNode) {

[jorsol]

It seems to be affected by the same but the overhead (which was the reported issue on Quarkus quarkusio/quarkus#39934) still misses the annotation:

kubernetes-client/kubernetes-model-generator/kubernetes-model-core/src/generated/java/io/fabric8/kubernetes/api/model/PodSpec.java

Lines 416 to 419 in 409be3b

	@JsonProperty("overhead")
	public Map<String, Quantity> getOverhead() {
	return overhead;
	}

[manusa]

Oh dear, I thought I checked that field specifically 🤦 🤦 🤦 🤦 🤦.