Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Enricher API : enricher.create is called twice by manager instead of enricher.enrich #1582

Closed
Beennnn opened this issue Mar 19, 2019 · 2 comments
Assignees

Comments

@Beennnn
Copy link

Beennnn commented Mar 19, 2019

In class EnricherManager, the enricher method calls enricher.create() instead of enricher.enrich() see https://github.com/fabric8io/fabric8-maven-plugin/blob/master/plugin/src/main/java/io/fabric8/maven/plugin/enricher/EnricherManager.java#L98
Consequently, the create() method is called twice.

Suggested fix: replace enricher.create(platformMode, builder); with enricher.enrich(platformMode, builder);

It is related to this commit : b3c6060

@rohanKanojia
Copy link
Member

🤒

@rohanKanojia
Copy link
Member

@Beennnn : Thanks for noticing, could you create a quick PR please? Otherwise, I would do it maybe today or tomorrow....

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants