Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings in browser console when using ColorWidget without specif… #145

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

fallen
Copy link
Contributor

@fallen fallen commented Jul 30, 2023

…ying format

Avoids the following warning:

Error: Option 'format' has invalid value:
    setOption http://0.0.0.0:8000/static/colorfield/jscolor/jscolor.js:2360
    pub http://0.0.0.0:8000/static/colorfield/jscolor/jscolor.js:3089
    installBySelector http://0.0.0.0:8000/static/colorfield/jscolor/jscolor.js:111
    install http://0.0.0.0:8000/static/colorfield/jscolor/jscolor.js:3381
    init http://0.0.0.0:8000/static/colorfield/jscolor/jscolor.js:3364
    register http://0.0.0.0:8000/static/colorfield/jscolor/jscolor.js:56
    jscolor http://0.0.0.0:8000/static/colorfield/jscolor/jscolor.js:3506
    <anonymous> http://0.0.0.0:8000/static/colorfield/jscolor/jscolor.js:3512
    <anonymous> http://0.0.0.0:8000/static/colorfield/jscolor/jscolor.js:32
    <anonymous> http://0.0.0.0:8000/static/colorfield/jscolor/jscolor.js:34

name: Pull request
about: Submit a pull request for this project
assignees: fabiocaccamo


Describe your changes
?

Related issue
?

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added tests for the proposed changes.
  • I have run the tests and there are not errors.

@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.20% ⚠️

Comparison is base (f3fa1b9) 88.35% compared to head (1b0f765) 87.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   88.35%   87.16%   -1.20%     
==========================================
  Files           7        7              
  Lines         146      148       +2     
==========================================
  Hits          129      129              
- Misses         17       19       +2     
Flag Coverage Δ
unittests 87.16% <0.00%> (-1.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
colorfield/widgets.py 52.63% <0.00%> (-6.20%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabiocaccamo fabiocaccamo merged commit b381aff into fabiocaccamo:main Jul 31, 2023
24 of 26 checks passed
fallen added a commit to pytition/Pytition that referenced this pull request Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants