Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] refactor initial parent object extraction #6

Closed
DumpySquare opened this issue Dec 10, 2020 · 1 comment
Closed

[RFE] refactor initial parent object extraction #6

DumpySquare opened this issue Dec 10, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@DumpySquare
Copy link
Member

DumpySquare commented Dec 10, 2020

When parsing the config files, the regex, for extracting the parent objects has some corner cases where it may miss some information, like closing brackets. It might not be that efficient with the use of lookbacks.

Furthermore, making this operation more efficient and streaming in file contents, could be the next big step in accuracy and performance improvements.

So, look at moving file input (after extracting from archive and saving locally), to stream in data as it's read, then test using the "balanced-matched" package to identify and extract each parent item object with all the necessary matched brackets and push them to the config array (or convert/merge into the final json tree

This would tie into #4

@DumpySquare DumpySquare added the enhancement New feature or request label Dec 10, 2020
@DumpySquare DumpySquare self-assigned this Dec 10, 2020
@DumpySquare
Copy link
Member Author

This work has pretty much been done with the latest async unpack and parse functions and balanced-matched has been in use for some time (almost two years now). The pending release of v1.0.0 removes most of this legacy code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant