Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple sources can be assigned the same device #52

Closed
N5FPP opened this issue Aug 19, 2017 · 5 comments
Closed

Multiple sources can be assigned the same device #52

N5FPP opened this issue Aug 19, 2017 · 5 comments
Assignees
Milestone

Comments

@N5FPP
Copy link

N5FPP commented Aug 19, 2017

While testing a previous bug I submitted. I noticed it is possible to add multiple source devices (R0, R1, etc.) and assign the same source device to all of them. This seems counter intuitive and should probably not be allowed - or at the very least a warning message saying the same device has been assigned to multiple sources.

If restricting assigning the same device to multiple devices is desired. I would recommend marking devices in the drop-down selection for other sampling devices as disabled depending if they have been previously assigned.

-Freeman, N5FPP

@f4exb
Copy link
Owner

f4exb commented Aug 22, 2017

I agree this is not foolproof assumption is that the user doesn't try to do odd things.

@f4exb
Copy link
Owner

f4exb commented Oct 27, 2017

The management of devices should be reworked in a better way. There are problems reported through other means than this board that multiple Rx or Tx (for now only LimeSDR) are not working properly. For example one cannot select the second Rx if the first is not already open.

This boils down to having a better enumeration of devices that can be more dynamic and which changes can be reported to appropriate listeners so that the actually available devices lists are updated.

@texasyojimbo
Copy link

texasyojimbo commented Oct 31, 2017

My comment on Issue #86 probably is related to this discussion and should have been grouped here.

@f4exb
Copy link
Owner

f4exb commented Oct 31, 2017

More elaboration on this subject:

  • Enumeration should be done and maintained (as plugins take and leave devices) in a single place as a singleton or attached to a singleton of the application
  • Enumeration should take care of device channel enumeration (ex: one Lime has 2 Rx and 2 Tx channels). In the way the application is designed a device is in fact a channel of a physical device.
  • The drop down list of devices and the checkbox need to be replaced by a dialog that will be filled at the dialog open time with the current list of available devices. The dialog is fired up with a push button (replacing the check button) or by clicking on the device text label. The "OK" button of the dialog will validate the change. Thus this is made dynamic and also is probably more intuitive. The identification of the device can be left as a text label in place of the drop down list. The dynamic dialog makes it more simple than using listeners on static widgets for the same or better functionality.

@f4exb f4exb self-assigned this Nov 1, 2017
@f4exb f4exb modified the milestones: v3.7.9, v3.8.0 Nov 1, 2017
@f4exb
Copy link
Owner

f4exb commented Nov 3, 2017

Implemented in v3.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants