Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger file generation appears incorrect #1821

Closed
srcejon opened this issue Sep 11, 2023 · 3 comments
Closed

Swagger file generation appears incorrect #1821

srcejon opened this issue Sep 11, 2023 · 3 comments

Comments

@srcejon
Copy link
Collaborator

srcejon commented Sep 11, 2023

If I run the swagger generate.sh script to generate the .cpp/.h files, I see a problem in the generated:

swagger/sdrangel/code/qt5/client/SWGRTTYModActions.h

It appears to contain references to PSK31ModActions. I can't see why this is happening though. There's no mention of PSK31 in RTTYMod.yaml and none to RTTYMod in PSK31.yaml. ChannelActions.yaml appears to point to the correct files.

Do you see the same problem?

@f4exb
Copy link
Owner

f4exb commented Sep 11, 2023

If I look at the present code on master I cannot see it: https://github.com/search?q=repo%3Af4exb%2Fsdrangel%20PSK31ModActions&type=code

@srcejon
Copy link
Collaborator Author

srcejon commented Sep 11, 2023

Yeah, I didn't check it in, as it wouldn't compile. So you'd need to run generate yourself.

@f4exb
Copy link
Owner

f4exb commented Sep 13, 2023

It seems the generator is confused by having the "payload" section exactly the same in both .yaml files. If I add a slightly different description for the "text" property in both .yaml files then the PSK31ModActions disappears in the RTTY mod files. While this is probably a bug in the generator it is simpler to have a different description,

@f4exb f4exb closed this as completed in af916d6 Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants