Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make autoloads ignore anonymous classes #1448

Merged
merged 1 commit into from
Dec 18, 2019
Merged

Make autoloads ignore anonymous classes #1448

merged 1 commit into from
Dec 18, 2019

Conversation

IotaBlack
Copy link
Contributor

No description provided.

@andrerom andrerom requested a review from emodric December 18, 2019 10:00
@andrerom andrerom merged commit 625d836 into ezsystems:2019.03 Dec 18, 2019
@emodric
Copy link
Collaborator

emodric commented Dec 18, 2019 •
edited
Loading

Having the following notice now, with the new tagged version:

Running script 'bin/php/ezpgenerateautoloads.php' in eZ Publish legacy context
Scanning for PHP-files.

Scan complete. Found 497 PHP files.

Searching for classes (tokenizing).
PHP Notice:  Undefined offset: -1 in /var/www/html/netgensite/ezpublish_legacy/kernel/private/classes/ezautoloadgenerator.php on line 646
PHP Notice:  Undefined offset: -1 in /var/www/html/netgensite/ezpublish_legacy/kernel/private/classes/ezautoloadgenerator.php on line 646
PHP Notice:  Undefined offset: -1 in /var/www/html/netgensite/ezpublish_legacy/kernel/private/classes/ezautoloadgenerator.php on line 646

Found 183 classes, added 183 of them to the autoload array.

@andrerom
Copy link
Contributor

So need to check existence of T_NEW constant then?
Would one of you be able to open PR?

@emodric
Copy link
Collaborator

emodric commented Dec 18, 2019

@andrerom #1450

@pkamps pkamps mentioned this pull request Jan 3, 2020
Merged
Opencontent pushed a commit to Opencontent/ezpublish-legacy that referenced this pull request Mar 17, 2020
@lrealdi
Merge commit 'c49eef93f50c665a3d7a6b2aa6387ccd46e059f5' into temp
69230ac 
* commit 'c49eef93f50c665a3d7a6b2aa6387ccd46e059f5':
  Removed invalid constructor call
  Fixed wrong old-style constructor usage
  EZP-31040: Remote Code Execution in file uploads
  Show images after used url_prefix (ezsystems#1453)
  improve php 7 bc doc (ezsystems#1452)
  Fix notice when checking for anonymous  classes in autoload generator (ezsystems#1450)
  Do not support literal HTML in the Administration Interface (ezsystems#1408)
  Fix transformURI() on ignoreIndexDir & ! htmlEscape (ezsystems#1449)
  Make autoloads ignore anonymous classes (ezsystems#1448)
  Update php7.md
  Fixing search in media lib which used to loose context (ezsystems#1433)
  [Travis] Add testing for PHP 7.2 and 7.3 (ezsystems#1446)
  EZP-30834: remove strtotime function from the trashed-days option (ezsystems#1441)
  Fix instances of count() that would cause a warning in 7.2
  Updated dbupdate scripts so they will no longer fail when there are multiple users with the same e-mail (ezsystems#1445)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emodric emodric emodric approved these changes

@andrerom andrerom andrerom approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IotaBlack @emodric @andrerom