EZP-29085: Force to use integer keys in eZXMLOutputHandler->NodeArray #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
More details are discussed on Slack with Gunnstein Lye |
glye
approved these changes
Apr 3, 2018
adamwojs
approved these changes
Apr 3, 2018
|
@l0rdJ Could you please make the commit text more descriptive? And if the two fixes are for separate issues, can you put them in separate commits, please? |
SerheyDolgushev
changed the title
eZXMLOutputHandler->NodeArray
SerheyDolgushev
changed the title
eZXMLOutputHandler->NodeArray
|
@glye i changed PR title and commit message. That two fixes are not separate, so they should be in the same commit. |
glye
changed the title
|
Sent to QA. |
andrerom
pushed a commit
that referenced
this pull request
Jun 29, 2018
(cherry picked from commit 4fcd80c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from Slack:
Seems like nodeID is forced to convert to string at https://github.com/ezsystems/ezpublish-legacy/blob/master/kernel/classes/datatypes/ezxmltext/ezxmloutputhandler.php#L278 and https://github.com/ezsystems/ezpublish-legacy/blob/master/kernel/classes/datatypes/ezxmltext/ezxmloutputhandler.php#L285
But http://php.net/manual/en/language.types.array.php says:
Additionally the following key casts will occur:
Strings containing valid decimal integers, unless the number is preceded by a + sign, will be cast to the integer type. E.g. the key “8” will actually be stored under 8. On the other hand “08" will not be cast, as it isn’t a valid decimal integer.
I.e. the string conversion is pointless, the array index will be an integer anyway.