EZP-28174: Improved error message when target of eznode:// and ezobject:// links doesn't exist #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmadejski
approved these changes
Nov 29, 2017
| @@ -1250,9 +1250,9 @@ function publishHandlerLink( $element, &$params ) | |||
| if ( !eZContentObject::exists( $objectID )) | |||
| { | |||
| $this->Messages[] = ezpI18n::tr( 'design/standard/ezoe/handler', | |||
| 'Object %1 does not exist.', | |||
| 'Invalid link: "%1" target object does not exist.', | |||
There was a problem hiding this comment.
Nitpick: inconsistency with other messages, missing : after "%1".
There was a problem hiding this comment.
Consider improvement like this:
Invalid link: "%1". Target object does not exist."
| @@ -1273,9 +1273,9 @@ function publishHandlerLink( $element, &$params ) | |||
| if ( !$node instanceOf eZContentObjectTreeNode ) | |||
| { | |||
| $this->Messages[] = ezpI18n::tr( 'design/standard/ezoe/handler', | |||
| 'Node %1 does not exist.', | |||
| 'Invalid link "%1": target node does not exist.', | |||
| @@ -1284,9 +1284,9 @@ function publishHandlerLink( $element, &$params ) | |||
| if ( !$node instanceOf eZContentObjectTreeNode ) | |||
| { | |||
| $this->Messages[] = ezpI18n::tr( 'design/standard/ezoe/handler', | |||
| 'Node '%1' does not exist.', | |||
| 'Invalid link "%1": target node does not exist.', | |||
…ct:// links doesn't exists
adamwojs
force-pushed
the
fix-ezp-28174
branch
from
22ca0d3 to
7bf3809
Compare
andrerom
approved these changes
Nov 29, 2017
jacek-foremski
approved these changes
Nov 29, 2017
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves an error message when target of
eznode://andezobject://links don't exist.