Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most Twitch clips failing to load #1406

Closed
retraenn opened this issue Aug 30, 2024 · 7 comments
Closed

Most Twitch clips failing to load #1406

retraenn opened this issue Aug 30, 2024 · 7 comments

Comments

@retraenn
Copy link
Contributor

ATTENTION! If you don't follow this template then your issue will be immediately closed.

Description of the problem

A lot of Twitch clips are not loading. The error I'm getting in my browser console is NS_BINDING_ABORTED.
I don't see a pattern to which clips work and which don't.
I'll include a broken and working example in the Steps below.
Here's a screenshot of the network tab error if it helps. https://i.imgur.com/nmCbOL4.png

Url of the page where the problem occurs (not the image url)

https://www.twitch.tv/

Steps to reproduce the problem (include image url here)

  1. This does not work https://www.twitch.tv/vedal987/clip/FlaccidTolerantCardTBTacoLeft-PqdJYwZ7itEPYzLS
  2. This one works. https://www.twitch.tv/geezgiselle/clip/ArtisticSuperPandaBCWarrior-J9kvPgtpeCCI3WUA

OS version, extension version

Windows 10
Firefox 129.0.2
Hoverzoom 1.0.219

@DeadOblivion78
Copy link

I'm experiencing the same issues. I'm also experiencing error 429 as well as this causes reddit to temporarily not load.

@retraenn
Copy link
Contributor Author

retraenn commented Sep 3, 2024

After messing around a little it looks like twitch returns no Clip URI for some reason on most clips.

I fixed the issue by changing Line 61 in plugins/twitch_a.js from
let clip_uri = t.clip_uri;
to
let clip_uri = r.data.clip.videoQualities[0].sourceURL;

It doesn't seem to break anything else but this probably isn't the proper way of fixing the issue, I don't really know what I'm doing but thought I'd leave this here in case it helps.

@zekecounter
Copy link

zekecounter commented Sep 15, 2024

same issue still persist

go to https://www.reddit.com/r/LivestreamFail/

then hover ur mouse cursor on one of the posted clips, You will only get the loading icon.

image

@zekecounter
Copy link

After messing around a little it looks like twitch returns no Clip URI for some reason on most clips.

I fixed the issue by changing Line 61 in plugins/twitch_a.js from let clip_uri = t.clip_uri; to let clip_uri = r.data.clip.videoQualities[0].sourceURL;

It doesn't seem to break anything else but this probably isn't the proper way of fixing the issue, I don't really know what I'm doing but thought I'd leave this here in case it helps.

how did u change this? i dont see an option in the extension that woud allow me to input this new change

@extesy
Copy link
Owner

extesy commented Oct 2, 2024

@retraenn do you mind submitting a pull request for your fix?

@retraenn
Copy link
Contributor Author

retraenn commented Oct 3, 2024

@retraenn do you mind submitting a pull request for your fix?

Done

@extesy
Copy link
Owner

extesy commented Oct 3, 2024

Fixed by #1424, will be available in the next release. Thank you, @retraenn!

@extesy extesy closed this as completed Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants