Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session Touch Reduction Option #892

Closed

Conversation

huntharo
Copy link

Fixes #891

@dougwilson
Copy link
Contributor

The touch action is meant for any session activity. If you need some other type of mechanism, please open an issue with what you are trying to achieve and we can work on some interface for it. Just based on the referenced issue, it seems there is confusion on what the purpose of touch is for.

@huntharo
Copy link
Author

@dougwilson - I legit opened an issue and linked it the description :)

touch only behaves as described now because there are no options to control its behavior. That is the point of this PR and Issue.

@dougwilson
Copy link
Contributor

Right, but that is the purpose of touch -- to be called every time there is activity on the session. If the store needs to throttle to it's storage mechanism, that is a store-specific concern that should be implemented in the store module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

session.touch is called on every request when resave: false
2 participants