Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write new guide on creating middleware for use with Express #461

Closed
crandmck opened this issue Oct 12, 2015 · 12 comments
Closed

Write new guide on creating middleware for use with Express #461

crandmck opened this issue Oct 12, 2015 · 12 comments
Assignees
Labels
docs Issues/pr concerning content

Comments

@crandmck
Copy link
Member

Per discussion and #454.

@hacksparrow
Copy link
Member

@crandmck
Copy link
Member Author

@ritch Is this sufficient for the time being? Do you think we should expand on the above article or can we close this issue?

@crandmck crandmck added docs Issues/pr concerning content #wip and removed #wip labels Oct 15, 2015
@crandmck crandmck assigned ritch and unassigned hacksparrow Oct 15, 2015
@ritch
Copy link
Member

ritch commented Oct 15, 2015

I think we can go a bit deeper. This looks like an introduction to writing middleware. Thinking from the perspective of a new middleware author I want to know the common patterns, things to avoid, etc. This is a good start but I think we are missing quite a bit.

@ritch ritch assigned crandmck and unassigned ritch Oct 15, 2015
@hacksparrow
Copy link
Member

@ritch what I can think of adding further is explaining "requireable" middleware, common module patterns, module.exports, and exports. Should that suffice? Anything else you have on mind?

Do you think we should cover publishing to npm as well?

@ritch
Copy link
Member

ritch commented Oct 16, 2015

@hacksparrow let's chat in realtime about this.

I think what you're suggesting is still a little too light. Maybe we need to split this into several guides this being the first.

@hacksparrow
Copy link
Member

@ritch I send you a mail.

@crandmck crandmck assigned ritch and unassigned crandmck Oct 29, 2015
@crandmck
Copy link
Member Author

@ritch If you still think we need more here, please advise.

@bajtos
Copy link

bajtos commented Dec 2, 2015

@ritch @hacksparrow @crandmck what's the status of this story? It has been sitting in #review column for 20 days by now. Can we close it as done?

@hacksparrow
Copy link
Member

@bajtos, @ritch and I had a discussion last time. What he wanted was a pretty detailed (multi-part) write up on Express middleware. Haven't had a chance yet, due to other priorities.

@bajtos
Copy link

bajtos commented Dec 2, 2015

@hacksparrow thank you for the update, makes sense. I'll move this story back to #tob column on our sprint board then.

@bajtos bajtos added #tob and removed #review labels Dec 2, 2015
@crandmck crandmck assigned hacksparrow and unassigned ritch Jan 15, 2016
@crandmck
Copy link
Member Author

@hacksparrow I reassigned back to you based on above comments. If you have anything (even a draft) written up, please share it, either in a branch or in the wiki. Then I can take it, if you have other priorities.

@crandmck crandmck added P2 and removed #tob labels Apr 28, 2016
@ryhinchey
Copy link
Contributor

@bajtos, @ritch and I had a discussion last time. What he wanted was a pretty detailed (multi-part) write up on Express middleware. Haven't had a chance yet, due to other priorities.

I'm going to go ahead and close this issue. If someone wants to add specifics as to what more we want to add to the site, please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues/pr concerning content
Projects
None yet
Development

No branches or pull requests

5 participants