Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#i18n-notice-box element is covered by header on homepage #1165

Closed
jonchurch opened this issue Jun 5, 2020 · 2 comments
Closed

#i18n-notice-box element is covered by header on homepage #1165

jonchurch opened this issue Jun 5, 2020 · 2 comments
Labels
bug help wanted

Comments

@jonchurch
Copy link
Member

I started a PR for this but wasn't satisfied by it, but note that w/ the alterations introduced by the BLM banner, our i18n notice box is being obscured on the homepage.

Screen Shot 2020-06-05 at 3 03 34 PM

To reproduce, visit http://expressjs.com/de/ in incognito mode (or otherwise clear the cookie value i18nClose).

The PR I started adjusted the margin-top and margin-bottom of the #i18n-notice-box, but that didn't work properly on pages such as http://expressjs.com/de/starter/installing.html
@jonchurch jonchurch mentioned this issue Jun 9, 2020
Merged
@dougwilson
Copy link
Contributor

@jonchurch does that PR #1162 fix this issue? I know you said related, but just didn't want to close this on merge of that PR if it didn't fully fix it, so wanted to validate first.

@dougwilson dougwilson mentioned this issue Jun 11, 2020
Closed
@jonchurch
Copy link
Member Author

jonchurch commented Jun 11, 2020 •
edited
Loading

Yep #1162 should close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dougwilson @jonchurch