This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[dev-client] Allow running projects without app.json #3371
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We allow bare projects to not have an
app.json
/ app config module, but previously trying to run a project without anapp.json
in dev client resulted in an error.How
This PR changes this so that when
app.json
exists, but we can detect a bundle identifier from the Xcode project, no error is thrown and we simply use the bundle identifier from the native project.Test Plan
Created an app using
npx crna -t with-dev-client
, removedapp.json
and verified thatexpod run:ios
works.