Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Updated metro config warning to reflect SDK 41 by default. #3325

Merged
merged 3 commits into from
Mar 25, 2021

Conversation

EvanBacon
Copy link
Contributor

Why

  • In SDK 41 the default metro config should be extending expo/metro-config (@expo/metro-config in older SDK versions).

How

Updated the warning when the config is modified to reflect the new default metro.config.js:

⚠️  Skipped Metro config updates:
› Existing Metro config found; not overwriting.
› You will need to extend the default @expo/metro-config in your Metro config.
  Learn more: https://docs.expo.io/guides/customizing-metro
  • Shortened configuration to config to match some other places in the CLI
  • Make the warning message a bit more deliberate as this is common behavior.

Test Plan

  • expo prebuild -p android --no-install
  • Modify the metro.config.js, repeating step 2 should log the new warning.
  • Optionally you can change the project SDK version to 41.0.0

@EvanBacon EvanBacon changed the title Updated metro config to reflect SDK 41 by default. Updated metro config warning to reflect SDK 41 by default. Mar 23, 2021
@EvanBacon EvanBacon merged commit 657832f into master Mar 25, 2021
@EvanBacon EvanBacon deleted the @evanbacon/eject/updated-metro-warning branch March 25, 2021 05:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant