This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[xdl] facebookReactNativeVersionToExpoVersionAsync: only map to released versions #3305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentvatne
approved these changes
Mar 19, 2021
brentvatne
deleted the
ville/eng-646-incorrect-mapping-of-a-react-native
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
facebookReactNativeVersionToExpoVersionAsyncwas mappingreact-nativeversions to SDK versions that were added to the versions endpoint, but not yet released. This PR makes it only map to released versions.Fixes #3288.
How
Used
releasedSdkVersionsAsyncto get applicable versions.Test Plan
Tested briefly in the
nodeconsole, following statements both printed '40.0.0' after the fix was done: