Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Added debug simctl logger #3293

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Conversation

EvanBacon
Copy link
Contributor

Why

How

  • Automatically attach logger when an app is launched from the terminal. Only attach when using devClient.

Test Plan

  • expo start --dev-client --ios
import * as React from "react";
import { View, Text } from "react-native";
import { usePermissions, CAMERA } from 'expo-permissions'

export default function App() {
  // Force a crash
  usePermissions(CAMERA, { ask: true })
  return (
    <View />
  );
}
  • expo start --ios no extra logs should be shown.

@EvanBacon EvanBacon requested review from fson and lukmccall March 17, 2021 00:53
Copy link
Contributor

@lukmccall lukmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good 💪

@EvanBacon EvanBacon marked this pull request as ready for review March 17, 2021 20:38
@EvanBacon EvanBacon merged commit 077cf32 into master Mar 17, 2021
@EvanBacon EvanBacon deleted the @evanbacon/simulator/attach-logs branch March 17, 2021 20:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants