This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[cli] Newline after full log output and skip newline before help output #3259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
approved these changes
Feb 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The newline before the help prompt on a clear screen was bothering me a bit. One solution is to remove the newline. Another alternative would be to add a newline after it too. I opted for the former, but could be convinced. Also, added a newline after the full help output because it looked a bit off to me without it.
Before
(you probably need to click on these to see)
Test Plan
Run
expo startand play with terminal UI to re-create the scenarios from screenshots.