This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[expo-cli] Improve handling of no answer for customize:web #3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I spent... too long not realizing I simply hadn't selected anything with space before hitting 'enter' in this menu. The instructional copy was low enough contrast I didn't notice it until after I went debugging here in the code. Briefly, the answer var will be an empty array if you didn't select anything but still hit "enter", and so this check will always be truthy in that case, firing the subsequent generate... function without any copy noting that... nothing happened. This PR clarifies the copy a bit, and makes sure it fires even when selection set is empty.
pckilgore
changed the title
EvanBacon
added
enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent... too long not realizing I simply hadn't selected anything with space before hitting 'enter' in this menu. The instructional copy was low enough contrast I didn't notice it until after I went debugging here in the code.
Briefly, the answer var will be an empty array if you didn't select anything but still hit "enter", and so this check will always be truthy in that case, firing the subsequent generate function without any copy noting that... nothing happened. This PR clarifies the copy a bit, and makes sure it fires even when selection set is empty.