Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[expo-cli] Auto-login when envvars are defined #3127

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Jan 26, 2021

Fixes #3119

When users define both EXPO_CLI_USERNAME and EXPO_CLI_PASSWORD, authenticate them. Even when using an interactive prompt.

Screenshot 2021-01-26 at 16 09 56

@byCedric byCedric requested a review from brentvatne January 26, 2021 15:06
Copy link
Contributor

@EvanBacon EvanBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but also add a test plan to the PR

@EvanBacon EvanBacon merged commit d226657 into master Jan 26, 2021
@EvanBacon EvanBacon deleted the @bycedric/fix/auto-login-envvar branch January 26, 2021 21:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not login from cli (expo publish) with env keys.
2 participants