Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[config] fill _internal object #2968

Merged
merged 3 commits into from
Nov 28, 2020
Merged

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Nov 28, 2020

  • Fill config._internal object with contents of ConfigContext -- this will make converting app.config.js function signature to ConfigPlugin easier.
  • Added config._internal.isDebug and config._internal.projectRoot from config.modRequest -- this makes config mods more like regular plugins, and will make static plugins easier to resolve from root.
  • Delete _internal in public configs to prevent exposing user computer file paths.

@EvanBacon EvanBacon added the Expo config Related to the app.json config for Expo projects label Nov 28, 2020
@EvanBacon EvanBacon requested a review from brentvatne November 28, 2020 00:01
@EvanBacon EvanBacon merged commit 6a7d03e into master Nov 28, 2020
@EvanBacon EvanBacon deleted the @evanbacon/config/fill-internal branch November 28, 2020 00:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Expo config Related to the app.json config for Expo projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant