This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[cli] Make it possible to run expo upgrade with beta release prior to setting flag #2967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… actually setting flag
brentvatne
commented
Nov 27, 2020
| ); | ||
| throw new CommandError( | ||
| `You provided the target SDK version value of ${targetSdkVersionString}, which does not seem to exist.\n` + | ||
| `Valid SDK versions are in the range of ${minSdkVersion}.0.0 to ${maxSdkVersion}.0.0.` |
There was a problem hiding this comment.
printing a range here because providing a list of SDK versions makes the error hard to read and will be even harder to read over time. might want to generalize to other places where we do the same thing
brentvatne
commented
Nov 27, 2020
| ); | ||
| if (getenv.boolish('EXPO_BETA', false)) { | ||
| log.gray( | ||
| `Release notes are not available for beta releases. Please refer to the CHANGELOG: https://github.com/expo/expo/blob/master/CHANGELOG.md.` |
There was a problem hiding this comment.
provide changelog rather than release notes when upgrading to beta release
brentvatne
commented
Nov 27, 2020
| if (!answer) { | ||
| return; | ||
| } | ||
| // If we still don't have a version, even after searching through unreleased versions |
There was a problem hiding this comment.
this changes existing behavior on expo upgrade for unknown sdk versions. these would not actually work anyways, so just actually bail out instead
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful so we can easily test standalone app builds on existing apps without needing to manually update deps or make the beta release publicly available through documented mechanisms.