Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[cli] delete generate-module #2903

Merged
merged 2 commits into from
Nov 18, 2020
Merged

[cli] delete generate-module #2903

merged 2 commits into from
Nov 18, 2020

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon requested a review from fson November 17, 2020 19:00
@EvanBacon EvanBacon mentioned this pull request Nov 17, 2020
Merged
@EvanBacon EvanBacon marked this pull request as ready for review November 18, 2020 08:48
@barthap
Copy link
Contributor

barthap commented Nov 18, 2020

As this is potentially the breaking change, what about adding a changelog entry?

@EvanBacon EvanBacon merged commit 0832198 into master Nov 18, 2020
@EvanBacon EvanBacon deleted the @evanbacon/cli/delete-generate-module branch November 18, 2020 12:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@barthap barthap barthap approved these changes

@fson fson Awaiting requested review from fson

Assignees
No one assigned
Labels
🧹 chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move generate-module elsewhere
2 participants
@EvanBacon @barthap