Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[dev-client][cli] Created scheme resolver #2861

Merged
merged 4 commits into from
Nov 6, 2020

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Nov 6, 2020

Created --dev-client flag for resolving the uri-scheme automatically or warning the user how to set one up. Pending scheme PR #2860. Kinda pending #2859 for improved Info.plist resolving.

States

Custom scheme

Screen Shot 2020-11-06 at 7 13 56 PM

--dev-client in an ejected project

Screen Shot 2020-11-06 at 7 14 35 PM

--dev-client in a mismatched URI scheme project

Screen Shot 2020-11-06 at 7 15 14 PM

--dev-client in a managed project

Screen Shot 2020-11-06 at 7 13 42 PM

@EvanBacon EvanBacon changed the title Created scheme resolver [dev-client][cli] Created scheme resolver Nov 6, 2020
Copy link
Member

@brentvatne brentvatne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

packages/expo-cli/src/schemes.ts Outdated Show resolved Hide resolved
@EvanBacon EvanBacon marked this pull request as ready for review November 6, 2020 18:12
packages/expo-cli/src/schemes.ts Outdated Show resolved Hide resolved
Co-authored-by: Brent Vatne <brentvatne@gmail.com>
@EvanBacon EvanBacon merged commit 240a8d9 into master Nov 6, 2020
@EvanBacon EvanBacon deleted the @evanbacon/cli/dev-client-flag branch November 6, 2020 18:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants