This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[cli] Fix requested sdk in upgrade command #2557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byCedric
force-pushed
the
@bycedric/cli/upgrade-fix-requrested-sdk-version
branch
from
3793a96 to
0c3c8fd
Compare
brentvatne
deleted the
@bycedric/cli/upgrade-fix-requrested-sdk-version
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2556
Why?
Becuase we didn't declare the optional
sdk-versionvalue you can provide, Commander returns the command instance torequestedSdkVersionparameter. This messes up two things:options.npmandoptions.yarn. But, due to 1, this is undefined and breaks the upgrade attempt.