This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[expo-cli] Eas build fix prompt for unsynced credentials #2546

Merged

wkozyra95 merged 2 commits into master from @wkozyra95/eas-build-fix-prompt-for-unsynced-credentials

Aug 31, 2020

Contributor

wkozyra95 commented Aug 31, 2020 •

edited

Loading

Why

When credentials exist both on Expo servers and in credntials.json, but Expo server ones are incomplete, expo-cli triggers generation of missing credentials when it supposes to just compare existing ones.
duplicated ensure credentials call

wkozyra95 added 2 commits

August 31, 2020 10:29


          [expo-cli] EAS Build: disable credentials generation on compare

b93bd75


          remove duplicated ensure credentials

024ba71

wkozyra95 requested a review from satya164

August 31, 2020 08:51

satya164 approved these changes

View reviewed changes

wkozyra95 merged commit 32efeb5 into master

wkozyra95 deleted the @wkozyra95/eas-build-fix-prompt-for-unsynced-credentials branch

August 31, 2020 12:40

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet