This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[xdl] update ios Podfile excluded unimodules for SDK 39 #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the iOS shell app build job in the expo/expo repo once we add SDK 39. Currently it's failing because the rendered Podfile in the shell app excludes unimodules that are needed in SDK 39 --
expo-splash-screenandexpo-updates. This PR will make the excluded dependencies in the rendered Podfile match the currentios/Podfilein the expo/expo repo, while also still supporting older SDK versions.Tested locally and the job succeeded.
TODO: we need to figure out a way to move this code out of XDL and into the expo repo -- at least determining the excluded unimodules, but potentially the entire process of generating the shell app workspace, now that we don't need to support ejecting to ExpoKit.