Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[expo-cli] cleanup apple id credentials logic #2409

Merged
merged 1 commit into from
Jul 29, 2020
Merged

[expo-cli] cleanup apple id credentials logic #2409

merged 1 commit into from
Jul 29, 2020

Conversation

wkozyra95
Copy link
Contributor

Why

  • bestEfortAppleCtx needs to be triggered before clearing credentials (because a user might want to revoke them)
  • removing unused code
  • env EXPO_APPLE_PASSWORD should be ignored if --apple-id is not specified( users in expo credentials:manager have seen error to specify apple-id even though that command does not support it)
  • passing appleId and password to ensureAppleCtx relies on the order of calls

quinlanj
quinlanj approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@quinlanj quinlanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@wkozyra95 wkozyra95 merged commit e1b2604 into master Jul 29, 2020
@wkozyra95 wkozyra95 deleted the @wkozyra95/cleanup-apple-id-credentials-logic branch July 29, 2020 07:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dsokal dsokal dsokal approved these changes

@quinlanj quinlanj quinlanj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkozyra95 @dsokal @quinlanj