This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
feat: use process.env.METRO_NODE_OPTIONS when starting Metro
#2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using NODE_OPTIONS from the expo-cli process, the Metro process overrides it with METRO_NODE_OPTIONS. This has two effects: (1) the expo-cli process can be debugged with --inspect-brk without causing an "address already in use" error in the Metro process, and (2) the Metro process can be debugged with --inspect-brk.
aleclarson
force-pushed
the
feat/metro-node-opts
branch
from
d886d5f
to
fde9e26
Compare
brentvatne
approved these changes
Jul 30, 2020
fson
approved these changes
Sep 3, 2020
There was a problem hiding this comment.
Thanks, seems good to me. 👍
Tip: as an alternative way to make debugging Metro easier, you can also use the new EXPO_USE_DEV_SERVER=true environment variable, which makes Metro run in the same process instead of a subprocess. (This feature is currently in beta, but we'll make it the default soon.)
|
The problem is now that the configured NODE_OPTIONS gets discarded completely. So if I previously used |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using
NODE_OPTIONSfrom theexpo-cliprocess, the Metro process overrides it withMETRO_NODE_OPTIONS.This has two effects:
--inspect-brkexpo-cliprocess can be debugged with--inspect-brkwithout causing an "address already in use" error in the Metro processFixes expo/expo#9398