This repository was archived by the owner on Jan 18, 2024. It is now read-only.
[expo-cli] upload:android - add better error messages for issues with downloading archive file #2384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkozyra95
approved these changes
Jul 22, 2020
packages/expo-cli/src/commands/upload/submission-service/utils/errors.ts
Outdated
Show resolved
Hide resolved
dsokal
commented
Jul 22, 2020
…/errors.ts Co-authored-by: Wojciech Kozyra <wojciech.kozyra@swmansion.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up PR to https://github.com/expo/turtle-v2/pull/258.
I've noticed that we're not providing good error messages when we failed to download the archive file.
There are two main reasons for this to happen:
In this PR, I'm adding proper error messages for these issues.