This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
fix(config): use basename to avoid mixed path separators from glob #2319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2312
Fixes #2326
I noticed
glob
returning paths with the forward-slash on Windows environments, even though thepath.sep
correctly returns a backslash. This uses thepath.basename
to resolve the last folder, regardless of the platform separator.To outline the issue, here is a log that I used in
getProjectName
to log the exact output of theprojectRoot
,sourceRoot
,sourceRootParts
,path.sep
, the bad result (old implementation), and the good result (new implementation):