Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[expo-cli] Combined ID prompts for build and eject #2313

Merged
merged 4 commits into from
Jul 1, 2020
Merged

[expo-cli] Combined ID prompts for build and eject #2313

merged 4 commits into from
Jul 1, 2020

Conversation

EvanBacon
Copy link
Contributor

  • The build:ios bundle ID prompt is awesome, this PR adds the same functionality for Android and shares the methods across expo eject, expo build:android, and expo build:ios

@EvanBacon EvanBacon marked this pull request as ready for review June 29, 2020 20:06
@EvanBacon EvanBacon merged commit 7f0d102 into master Jul 1, 2020
@EvanBacon EvanBacon deleted the @evanbacon/expo-cli/prompt-ids branch July 1, 2020 22:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brentvatne brentvatne Awaiting requested review from brentvatne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@EvanBacon