Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

IOS build and upload commands should rely on the same env vars #2280

Closed
cruzach opened this issue Jun 17, 2020 · 1 comment · Fixed by #2358
Closed

IOS build and upload commands should rely on the same env vars #2280

cruzach opened this issue Jun 17, 2020 · 1 comment · Fixed by #2358

Comments

@cruzach
Copy link
Contributor

cruzach commented Jun 17, 2020

expo build:ios expects the EXPO_APPLE_PASSWORD env variable, whereas expo upload:ios expects the EXPO_APPLE_ID_PASSWORD env variable. Unless there's a reason to have these be two different keys, it would avoid confusion to use the same one in both scenarios

Since this would be a breaking change, we can wait to fix this until we are about ready to ship a new major version. It's an easy change to make, but could cause a headache for people who are accustomed to the current workflow

@1337LutZ
Copy link

1337LutZ commented Jul 4, 2020

expo build:ios expects the EXPO_APPLE_PASSWORD env variable, whereas expo upload:ios expects the EXPO_APPLE_ID_PASSWORD env variable. Unless there's a reason to have these be two different keys, it would avoid confusion to use the same one in both scenarios

Since this would be a breaking change, we can wait to fix this until we are about ready to ship a new major version. It's an easy change to make, but could cause a headache for people who are accustomed to the current workflow

I vote for this as well. Now we are managing 2 different keys in 3 projects. Couldn't we gracefully deprecate it? Make it work for x amount of expo-cli versions whilst showing a warning message?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants