From e30000e5ef67a69920ca9676b8710ce403acc705 Mon Sep 17 00:00:00 2001 From: Brent Vatne Date: Tue, 14 Apr 2020 14:22:34 -0700 Subject: [PATCH] Default to bundleIdentifier value for package when prompted in eject --- packages/expo-cli/src/commands/eject/Eject.ts | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/packages/expo-cli/src/commands/eject/Eject.ts b/packages/expo-cli/src/commands/eject/Eject.ts index b3ee3d4144..708a649659 100644 --- a/packages/expo-cli/src/commands/eject/Eject.ts +++ b/packages/expo-cli/src/commands/eject/Eject.ts @@ -234,7 +234,7 @@ async function createNativeProjectsFromTemplateAsync(projectRoot: string): Promi appJson.expo.ios = appJson.expo.ios ?? {}; appJson.expo.ios.bundleIdentifier = bundleIdentifier; - let packageName = await getOrPromptForPackage(projectRoot); + let packageName = await getOrPromptForPackage(projectRoot, bundleIdentifier); appJson.expo.android = appJson.expo.android ?? {}; appJson.expo.android.package = packageName; @@ -420,7 +420,10 @@ async function promptForNativeAppNameAsync(projectRoot: string): Promise return name!; } -async function getOrPromptForBundleIdentifier(projectRoot: string): Promise { +async function getOrPromptForBundleIdentifier( + projectRoot: string, + defaultValue?: string +): Promise { let { exp } = getConfig(projectRoot); if (exp.ios?.bundleIdentifier) { @@ -438,6 +441,7 @@ async function getOrPromptForBundleIdentifier(projectRoot: string): Promise /^[a-zA-Z][a-zA-Z0-9\-.]+$/.test(value), }, @@ -447,7 +451,7 @@ async function getOrPromptForBundleIdentifier(projectRoot: string): Promise { +async function getOrPromptForPackage(projectRoot: string, defaultValue?: string): Promise { let { exp } = getConfig(projectRoot); if (exp.android?.package) { @@ -465,6 +469,7 @@ async function getOrPromptForPackage(projectRoot: string): Promise { const { packageName } = await prompt([ { name: 'packageName', + default: defaultValue, message: `What would you like your package to be named?`, validate: (value: string) => /^[a-zA-Z][a-zA-Z0-9\-.]+$/.test(value), },