From 81cb78bf941b899184e04ea614b071bcc7e0cec6 Mon Sep 17 00:00:00 2001 From: Eric Samelson Date: Tue, 14 Jul 2020 19:43:48 -0700 Subject: [PATCH] [xdl] fix analytics for expo start (#2357) --- packages/xdl/src/Project.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/xdl/src/Project.ts b/packages/xdl/src/Project.ts index 84f73f1048..39336cd284 100644 --- a/packages/xdl/src/Project.ts +++ b/packages/xdl/src/Project.ts @@ -2036,7 +2036,10 @@ export async function getSignedManifestStringAsync( if (_cachedSignedManifest.manifestString === manifestString) { return _cachedSignedManifest.signedManifest; } - const { response } = await ApiV2.clientForUser(currentSession).postAsync('manifest/sign', { + // WARNING: Removing the following line will regress analytics, see: https://github.com/expo/expo-cli/pull/2357 + // TODO: make this more obvious from code + const user = await UserManager.ensureLoggedInAsync(); + const { response } = await ApiV2.clientForUser(user).postAsync('manifest/sign', { args: { remoteUsername: manifest.owner ?? (await UserManager.getCurrentUsernameAsync()), remotePackageName: manifest.slug,