Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html5lib==1.0b8 is required in the 2.0.9 release but not in git repository #2100

Closed
raphael0202 opened this issue Mar 15, 2018 · 3 comments
Closed

html5lib==1.0b8 is required in the 2.0.9 release but not in git repository #2100

raphael0202 opened this issue Mar 15, 2018 · 3 comments
Labels
meta Meta topics, e.g. repo organisation and issue management

Comments

@raphael0202
Copy link
Contributor

html5lib requirement was dropped in this commit: 6bba1db#diff-b4ef698db8ca845e5845c4618278f29a

However, we can still find html5lib==1.0b8 in setup.py and requirements.txt in the 2.0.9 release.
This version of html5lib is incompatible with Tensorflow 1.5.0, which needs htm5lib==0.9999999

Your Environment

  • Platform: Linux-4.4.0-116-generic-x86_64-with-Ubuntu-16.04-xenial
  • spaCy version: 2.0.9
  • Python version: 3.5.2
@ines
Copy link
Member

ines commented Mar 15, 2018

Ah yeah, I think we just pushed v2.0.9 from a hotfix branch to offer a solution for the msgpack problem. Because it was quite rushed, we didn't port that particular commit over (to not risk breaking something). v2.1.0 will defintely include that fix, though, and will drop the html5lib dependency 🎉

@raphael0202
Copy link
Contributor Author

Great, thanks for the quick response 👍

@ines ines added the meta Meta topics, e.g. repo organisation and issue management label Mar 27, 2018
@ines ines closed this as completed Mar 27, 2018
@romanczuk romanczuk mentioned this issue Apr 3, 2018
Closed
@lock
Copy link

lock bot commented May 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
meta Meta topics, e.g. repo organisation and issue management
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raphael0202 @ines