Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR to PyMC3? #4

Closed
twiecki opened this issue Nov 2, 2020 · 3 comments
Closed

PR to PyMC3? #4

twiecki opened this issue Nov 2, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@twiecki
Copy link

twiecki commented Nov 2, 2020

A lot of these changes, specifically those for tuning would be a great addition to PyMC3 directly. Have you considered PRing them upstream?
@twiecki twiecki added the enhancement New feature or request label Nov 2, 2020
@dfm
Copy link
Member

dfm commented Nov 2, 2020

Thanks Thomas!

I've thought about that and the adapt_full algorithm was developed here and pushed upstream. I think that the current changes are experimental enough (and I'm not yet sure how much benefit they provide) that they're not ready for a PR, but I'll definitely do it when/if I have convincing evidence for some piece of this!

@twiecki
Copy link
Author

twiecki commented Jun 14, 2022

There is now also https://github.com/pymc-devs/pymc-experimental/

@dfm
Copy link
Member

dfm commented Oct 20, 2022

Closing because it's looking like this is going to continue to be necessary for our community alas!

@dfm dfm closed this as not planned Won't fix, can't repro, duplicate, stale Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dfm @twiecki